#15889: Fix handling of mantissa rounding to respect ties round to even #16997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT-BrianLiu
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
TT-BrianLiu
force-pushed
the
bliu/main2
branch
from
ad64313 to
842747f
Compare
ayerofieiev-tt
approved these changes
Jan 22, 2025
TT-BrianLiu
force-pushed
the
bliu/main2
branch
from
842747f to
6828830
Compare
TT-BrianLiu
requested review from
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
razorback3,
dongjin-na and
bbradelTT
as code owners
bbradelTT
approved these changes
Jan 23, 2025
TT-BrianLiu
force-pushed
the
bliu/main2
branch
from
6828830 to
61b4719
Compare
TT-BrianLiu
requested review from
patrickroberts,
yan-zaretskiy and
eyonland
as code owners
TT-BrianLiu
force-pushed
the
bliu/main2
branch
from
61b4719 to
2227880
Compare
TT-BrianLiu
force-pushed
the
bliu/main2
branch
from
2227880 to
eafe09c
Compare
This was referenced Jan 28, 2025
TT-BrianLiu
force-pushed
the
bliu/main2
branch
from
eafe09c to
5d8ca3a
Compare
TT-BrianLiu
requested review from
uaydonat,
djordje-tt and
johanna-rock-tt
as code owners
TT-BrianLiu
force-pushed
the
bliu/main2
branch
from
5d8ca3a to
244d6ff
Compare
abhullar-tt
approved these changes
Jan 28, 2025
yan-zaretskiy
approved these changes
Jan 28, 2025
uaydonat
approved these changes
Jan 28, 2025
TT-BrianLiu
force-pushed
the
bliu/main2
branch
3 times, most recently
from
ffde881 to
ed50ad6
Compare
- Add tt_metal gtest to test convert_u32_to_bfp rounding logic for bfp8
- Remove unused functions in tt_metal/api/tt-metalium/bfloat8.hpp
- Update impacted tests/models to reflect minor differences
* Minor pcc adjustment in op tests
* Skip typecast for bfp16 to bfp8 (issue 17237)
* Update expected demo output for Falcon40B demo test
** This will break CI which uses cached bfp8 weights
** Model weights need to be re-generated and cached
TT-BrianLiu
force-pushed
the
bliu/main2
branch
from
ed50ad6 to
437c9b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
See issue for more context and examples. When we handle rounding of mantissa when going from float to block float, we always round to nearest (ties always round up), which doesn't folow the "ties round to even" rule. This PR fixes that and adds lower c++ tests to test the different cases.
What's changed
Checklist